Skip to content

Adding RedisGraph support #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 30, 2021
Merged

Adding RedisGraph support #1673

merged 18 commits into from
Nov 30, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Nov 8, 2021 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add support to Graph commands (taken from redisplus-py)

@chayim chayim added 4.1.0 feature New feature labels Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #1673 (3f8850f) into master (b94e230) will decrease coverage by 0.05%.
The diff coverage is 90.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   90.91%   90.86%   -0.06%     
==========================================
  Files          59       70      +11     
  Lines       14229    15185     +956     
==========================================
+ Hits        12937    13798     +861     
- Misses       1292     1387      +95
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
redis/commands/helpers.py 87.09% <61.11%> (-4.91%) ⬇️
redis/commands/graph/exceptions.py 66.66% <66.66%> (ø)
redis/commands/graph/path.py 79.62% <79.62%> (ø)
redis/commands/graph/commands.py 84.50% <84.50%> (ø)
redis/commands/graph/query_result.py 87.67% <87.67%> (ø)
tests/test_graph.py 89.92% <89.92%> (ø)
redis/commands/graph/__init__.py 92.39% <92.39%> (ø)
tests/test_graph_utils/test_edge.py 97.29% <97.29%> (ø)
redis/commands/graph/node.py 97.77% <97.77%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94e230...3f8850f. Read the comment docs.

@chayim chayim changed the title Support graph module Adding RedisGraph support Nov 30, 2021
@chayim chayim merged commit 175a05f into redis:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim Awaiting requested review from chayim

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AvitalFineRedis @codecov-commenter @chayim